Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

Migrate to monorepo #149

Merged
merged 94 commits into from
Oct 11, 2023
Merged

Migrate to monorepo #149

merged 94 commits into from
Oct 11, 2023

Conversation

NikhilVerma
Copy link
Contributor

@NikhilVerma NikhilVerma commented Oct 7, 2023 •
edited by vikas-cldcvr
Loading

Goal

  • Unify flow package development and release (monorepo)
  • Improve feedback channels (github issue template, labels, process)
  • Improve technical stack (Storybook 7, CSS duplication)
  • Improve integration process (Better CI, lint, release flows)

Technical to-do

  • Migrate flow components to monorepo
  • Improve technical stack
    • Migrate to storybook v7
      • Update stories
    • Remove duplicate CSS imports
    • Composite typescript setup
    • Parallel builds using pnpm run
  • Process improvements
    • Update issue template with stack blitz example
    • Migrate recently reported issues from Slack to Github
  • Improve integration process
    • Migrate to pnpm
    • Add lint checks (pre-push)
    • Add lint checks (CI)

@datapipes-robot
Copy link

@NikhilVerma: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 7, 2023
View reviewed changes
packages/flow-lineage/src/components/f-lineage/f-lineage.ts
variant="curved"
gap="small"
\${node.fChildren && !node.fHideChildren ? 'border="small solid default bottom"' : ""}
> <f-text variant="code" size="large" state="danger">Error reading node ${node.id}.fData</f-text>

Check warning

Code scanning / CodeQL

Unsafe HTML constructed from library input Medium

This HTML construction which depends on
library input
Loading
might later allow
cross-site scripting
Loading
.
This HTML construction which depends on
library input
Loading
might later allow
cross-site scripting
Loading
.
This HTML construction which depends on
library input
Loading
might later allow
cross-site scripting
Loading
.
This HTML construction which depends on
library input
Loading
might later allow
cross-site scripting
Loading
.
NikhilVerma and others added 20 commits October 7, 2023 18:21
@NikhilVerma
monorepo Format code
464fb4d
@NikhilVerma
monorepo Add missing modules for storybook
371c12c
monorepo lineage stories updated
0b4be1e
@NikhilVerma
monorepo WIP
1164d00
@NikhilVerma
monorepo Fix building and formatting
8a33bbd
monorepo web-runner port updated
01eb5b2
@NikhilVerma
monorepo Make all packages independent of one another
5043bdd
@NikhilVerma
monorepo Merge remote-tracking branch 'origin/monorepo' into monorepo
a246c68
@NikhilVerma
monorepo Minor tweaks
65f5548
@NikhilVerma
monorepo Delete custom JSON files
519f196
@NikhilVerma
monorepo Ignore custom json artifacts
291ead0
@NikhilVerma
monorepo Add linting and lint-staged support
66d3f25
@NikhilVerma
monorepo Fix formatting
59824f2
monorepo f-accordion and f-breadcrumb global styles updated
1662ccf
@NikhilVerma
monorepo Add flow-config as a dependency to flow-core
3ea5b0d
@NikhilVerma
monorepo Merge branch 'monorepo' of https://github.com/cldcvr/flow-core…
121963e 
… into monorepo
monorepo f-carousel global styles updated
e9f0ba6
monorepo f-checkbox global styles added
b9c11c6
monorepo f-counter global styles updated
afcd9bc
monorepo f-date-time-picker global styles added
021f4b7
@NikhilVerma NikhilVerma marked this pull request as ready for review October 11, 2023 04:29
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 381 Code Smells

No Coverage information No Coverage information
5.3% 5.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@datapipes-robot datapipes-robot bot added the lgtm label Oct 11, 2023
@vikas-cldcvr vikas-cldcvr merged commit 404f307 into main Oct 11, 2023
5 of 6 checks passed
@vikas-cldcvr vikas-cldcvr deleted the monorepo branch October 11, 2023 07:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vikas-cldcvr vikas-cldcvr vikas-cldcvr approved these changes

Assignees

@vikas-cldcvr vikas-cldcvr

Labels
do-not-merge/contains-merge-commits lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NikhilVerma @vikas-cldcvr